[breaking, deploy server first] fix(ai-chat): persist providerExecuted flag on tool parts (#20030)

## Summary Fixes Sentry errors of the form: > \`messages.3: \`tool_use\` ids were found without \`tool_result\` blocks immediately after: srvtoolu_…. Each \`tool_use\` block must have a corresponding \`tool_result\` block in the next message.\` ### Root cause When the model invokes a **provider-hosted tool** (e.g. Anthropic's native \`web_search\` — note the \`srvtoolu_\` ID prefix), the AI SDK marks the resulting \`UIMessagePart\` with \`providerExecuted: true\`. \`convertToModelMessages\` uses that flag to emit the tool_use/tool_result pair *inside the same assistant message* — the format Anthropic requires for server-side tools. Our \`AgentMessagePart\` persistence was dropping \`providerExecuted\` on the way to the DB (and re-hydration didn't know to set it). On the next turn, \`convertToModelMessages\` treated the rehydrated part as a client-side tool call, splitting it into \`assistant(tool_use)\` + \`user(tool_result)\` — which Anthropic then rejects with the error above. ### Fix - Add nullable \`providerExecuted BOOLEAN\` column on \`core.agentMessagePart\` via a fast instance command. - Surface the field on \`AgentMessagePartDTO\` (GraphQL). - Preserve it through \`mapUIMessagePartsToDBParts\` (server) and both \`mapDBPartToUIMessagePart\` mappers (server + frontend). - Include it in \`GET_CHAT_MESSAGES\` and \`GET_AGENT_TURNS\` selections. - Regenerate \`generated-metadata/graphql.ts\`. ### Backwards compatibility Existing rows have \`NULL providerExecuted\` and round-trip as the omitted flag — which is exactly the pre-fix behaviour for tool parts that were never provider-executed. Only *new* assistant messages using \`web_search\` (or other provider-hosted tools) will write \`true\`, and those are the only ones that were breaking. ## Test plan - [x] \`npx tsgo\` typecheck — server + front clean - [x] \`oxlint\` + \`prettier --check\` on all touched files — clean - [x] \`npx nx run twenty-server:database:migrate:prod\` runs the new instance command locally; \`providerExecuted\` column present on \`core.agentMessagePart\` - [x] Regenerated \`generated-metadata/graphql.ts\` — \`providerExecuted\` wired into both queries and \`AgentMessagePart\` type - [ ] Manual: start a chat with Anthropic web_search enabled, invoke the tool in turn 1, reply in turn 2 — should not throw the srvtoolu error 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 16:58:26 +02:00
parent 5f604a503a
commit 251f5deab6
20 changed files with 84 additions and 22 deletions
@@ -26,13 +26,13 @@ export class TestFastInstanceCommand implements FastInstanceCommand {
 exports[`InstanceCommandGenerationService should escape backslashes in SQL queries 1`] = `
 {
  "className": "UpdatePathFastInstanceCommand",
-  "fileName": "2-0-instance-command-fast-1775000000000-update-path.ts",
+  "fileName": "2-1-instance-command-fast-1775000000000-update-path.ts",
  "fileTemplate": "import { QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000)
+@RegisteredInstanceCommand('2.1.0', 1775000000000)
 export class UpdatePathFastInstanceCommand implements FastInstanceCommand {
  public async up(queryRunner: QueryRunner): Promise<void> {
    await queryRunner.query('UPDATE "core"."config" SET "value" = E\\'path\\\\\\\\to\\\\\\\\file\\'');
@@ -49,13 +49,13 @@ export class UpdatePathFastInstanceCommand implements FastInstanceCommand {
 exports[`InstanceCommandGenerationService should escape single quotes in SQL queries 1`] = `
 {
  "className": "UpdateConfigFastInstanceCommand",
-  "fileName": "2-0-instance-command-fast-1775000000000-update-config.ts",
+  "fileName": "2-1-instance-command-fast-1775000000000-update-config.ts",
  "fileTemplate": "import { QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000)
+@RegisteredInstanceCommand('2.1.0', 1775000000000)
 export class UpdateConfigFastInstanceCommand implements FastInstanceCommand {
  public async up(queryRunner: QueryRunner): Promise<void> {
    await queryRunner.query('UPDATE "core"."config" SET "value" = \\'it\\'\\'s done\\'');
@@ -72,13 +72,13 @@ export class UpdateConfigFastInstanceCommand implements FastInstanceCommand {
 exports[`InstanceCommandGenerationService should generate a migration with a single up/down query 1`] = `
 {
  "className": "AddFooColumnFastInstanceCommand",
-  "fileName": "2-0-instance-command-fast-1775000000000-add-foo-column.ts",
+  "fileName": "2-1-instance-command-fast-1775000000000-add-foo-column.ts",
  "fileTemplate": "import { QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000)
+@RegisteredInstanceCommand('2.1.0', 1775000000000)
 export class AddFooColumnFastInstanceCommand implements FastInstanceCommand {
  public async up(queryRunner: QueryRunner): Promise<void> {
    await queryRunner.query('ALTER TABLE "core"."user" ADD "foo" varchar');
@@ -95,13 +95,13 @@ export class AddFooColumnFastInstanceCommand implements FastInstanceCommand {
 exports[`InstanceCommandGenerationService should generate a migration with multiple queries 1`] = `
 {
  "className": "CreateTaskTableFastInstanceCommand",
-  "fileName": "2-0-instance-command-fast-1775000000000-create-task-table.ts",
+  "fileName": "2-1-instance-command-fast-1775000000000-create-task-table.ts",
  "fileTemplate": "import { QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000)
+@RegisteredInstanceCommand('2.1.0', 1775000000000)
 export class CreateTaskTableFastInstanceCommand implements FastInstanceCommand {
  public async up(queryRunner: QueryRunner): Promise<void> {
    await queryRunner.query('CREATE TABLE "core"."task" ("id" uuid NOT NULL DEFAULT uuid_generate_v4(), "name" varchar NOT NULL)');
@@ -120,13 +120,13 @@ export class CreateTaskTableFastInstanceCommand implements FastInstanceCommand {
 exports[`InstanceCommandGenerationService should generate a migration with query parameters 1`] = `
 {
  "className": "SeedSettingFastInstanceCommand",
-  "fileName": "2-0-instance-command-fast-1775000000000-seed-setting.ts",
+  "fileName": "2-1-instance-command-fast-1775000000000-seed-setting.ts",
  "fileTemplate": "import { QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000)
+@RegisteredInstanceCommand('2.1.0', 1775000000000)
 export class SeedSettingFastInstanceCommand implements FastInstanceCommand {
  public async up(queryRunner: QueryRunner): Promise<void> {
    await queryRunner.query('INSERT INTO "core"."setting" ("key", "value") VALUES ($1, $2)', ["theme","dark"]);
@@ -143,13 +143,13 @@ export class SeedSettingFastInstanceCommand implements FastInstanceCommand {
 exports[`InstanceCommandGenerationService should generate a slow instance command with populated up/down 1`] = `
 {
  "className": "MakeColumnNotNullableSlowInstanceCommand",
-  "fileName": "2-0-instance-command-slow-1775000000000-make-column-not-nullable.ts",
+  "fileName": "2-1-instance-command-slow-1775000000000-make-column-not-nullable.ts",
  "fileTemplate": "import { DataSource, QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { SlowInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/slow-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000, { type: 'slow' })
+@RegisteredInstanceCommand('2.1.0', 1775000000000, { type: 'slow' })
 export class MakeColumnNotNullableSlowInstanceCommand implements SlowInstanceCommand {
  async runDataMigration(dataSource: DataSource): Promise<void> {
    // TODO: implement data backfill before the DDL migration
@@ -170,13 +170,13 @@ export class MakeColumnNotNullableSlowInstanceCommand implements SlowInstanceCom
 exports[`InstanceCommandGenerationService should use default migration name in class and file names 1`] = `
 {
  "className": "AutoGeneratedFastInstanceCommand",
-  "fileName": "2-0-instance-command-fast-1775000000000-auto-generated.ts",
+  "fileName": "2-1-instance-command-fast-1775000000000-auto-generated.ts",
  "fileTemplate": "import { QueryRunner } from 'typeorm';

 import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
 import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';

-@RegisteredInstanceCommand('2.0.0', 1775000000000)
+@RegisteredInstanceCommand('2.1.0', 1775000000000)
 export class AutoGeneratedFastInstanceCommand implements FastInstanceCommand {
  public async up(queryRunner: QueryRunner): Promise<void> {
    await queryRunner.query('ALTER TABLE "core"."user" ADD "bar" integer');
@@ -0,0 +1,21 @@
+import { QueryRunner } from 'typeorm';
+
+import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
+import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
+
+@RegisteredInstanceCommand('2.1.0', 1777012800000)
+export class AddProviderExecutedToAgentMessagePartFastInstanceCommand
+  implements FastInstanceCommand
+{
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      'ALTER TABLE "core"."agentMessagePart" ADD "providerExecuted" boolean',
+    );
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      'ALTER TABLE "core"."agentMessagePart" DROP COLUMN "providerExecuted"',
+    );
+  }
+}
@@ -0,0 +1,7 @@
+import { Module } from '@nestjs/common';
+
+@Module({
+  imports: [],
+  providers: [],
+})
+export class V2_2_UpgradeVersionCommandModule {}
@@ -16,6 +16,7 @@ import { AddGlobalObjectContextToCommandMenuItemAvailabilityTypeFastInstanceComm
 import { AddPageLayoutIdToCommandMenuItemFastInstanceCommand } from 'src/database/commands/upgrade-version-command/1-23/1-23-instance-command-fast-1776168404836-add-page-layout-id-to-command-menu-item';
 import { AddConditionalAvailabilityExpressionToPageLayoutWidgetFastInstanceCommand } from 'src/database/commands/upgrade-version-command/1-23/1-23-instance-command-fast-1775654781000-add-conditional-availability-expression-to-page-layout-widget';
 import { AddIsPreInstalledToApplicationRegistrationFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-0/2-0-instance-command-fast-1776886452831-add-is-pre-installed-to-application-registration';
+import { AddProviderExecutedToAgentMessagePartFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-1/2-1-instance-command-fast-1777012800000-add-provider-executed-to-agent-message-part';
 import { BackfillPageLayoutWidgetPositionSlowInstanceCommand } from 'src/database/commands/upgrade-version-command/2-1/2-1-instance-command-slow-1795000002000-backfill-page-layout-widget-position';

 export const INSTANCE_COMMANDS = [
@@ -35,5 +36,6 @@ export const INSTANCE_COMMANDS = [
  AddPageLayoutIdToCommandMenuItemFastInstanceCommand,
  AddConditionalAvailabilityExpressionToPageLayoutWidgetFastInstanceCommand,
  AddIsPreInstalledToApplicationRegistrationFastInstanceCommand,
+  AddProviderExecutedToAgentMessagePartFastInstanceCommand,
  BackfillPageLayoutWidgetPositionSlowInstanceCommand,
 ];
@@ -5,6 +5,7 @@ import { V1_22_UpgradeVersionCommandModule } from 'src/database/commands/upgrade
 import { V1_23_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/1-23/1-23-upgrade-version-command.module';
 import { V2_0_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-0/2-0-upgrade-version-command.module';
 import { V2_1_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-1/2-1-upgrade-version-command.module';
+import { V2_2_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-2/2-2-upgrade-version-command.module';

@Module({
  imports: [
@@ -13,6 +14,7 @@ import { V2_1_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-
    V1_23_UpgradeVersionCommandModule,
    V2_0_UpgradeVersionCommandModule,
    V2_1_UpgradeVersionCommandModule,
+    V2_2_UpgradeVersionCommandModule,
  ],
 })
 export class WorkspaceCommandProviderModule {}