Label identifier validation v2 (#14867)

# Introduction
Adding a hacky way to validate object against fields before fields
validation ( bi-directional validation process )
If you encounter an identical setup we will add a specific devXp as
cleanup validation but for the moment this seems enough

close https://github.com/twentyhq/core-team-issues/issues/1639

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/find-all-others-morph-relation-flat-field-metadatas-or-throw.util.ts

@@ -7,7 +7,7 @@ import {
 } from 'src/engine/core-modules/common/exceptions/flat-entity-maps.exception';
 import { type FlatEntityMaps } from 'src/engine/core-modules/common/types/flat-entity-maps.type';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { findObjectFieldsInFlatFieldMetadataMapsOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util';
+import { findObjectFlatFieldMetadatasOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util';
 import { isFlatFieldMetadataOfType } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-type.util';
 import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
 
@@ -30,11 +30,10 @@ export const findAllOthersMorphRelationFlatFieldMetadatasOrThrow = ({
     );
   }
 
-  const { objectFlatFieldMetadatas } =
-    findObjectFieldsInFlatFieldMetadataMapsOrThrow({
-      flatFieldMetadataMaps,
-      flatObjectMetadata,
-    });
+  const { objectFlatFieldMetadatas } = findObjectFlatFieldMetadatasOrThrow({
+    flatFieldMetadataMaps,
+    flatObjectMetadata,
+  });
 
   return objectFlatFieldMetadatas.filter(
     (

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util.ts

@@ -9,24 +9,22 @@ type FindObjectFieldsInFlatFieldMetadataMapsArgs = {
   flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>;
   flatObjectMetadata: FlatObjectMetadata;
 };
-export const findObjectFieldsInFlatFieldMetadataMapsOrThrow = ({
+export const findObjectFlatFieldMetadatasOrThrow = ({
   flatFieldMetadataMaps,
   flatObjectMetadata,
 }: FindObjectFieldsInFlatFieldMetadataMapsArgs): {
-  objectFlatFieldMetadataById: FlatEntityMaps<FlatFieldMetadata>;
   objectFlatFieldMetadatas: FlatFieldMetadata[];
 } => {
-  const objectFlatFieldMetadataById = getSubFlatEntityMapsOrThrow({
+  const objectFlatFieldMetadataMaps = getSubFlatEntityMapsOrThrow({
     flatEntityIds: flatObjectMetadata.fieldMetadataIds,
     flatEntityMaps: flatFieldMetadataMaps,
   });
 
   const objectFlatFieldMetadatas = Object.values(
-    objectFlatFieldMetadataById.byId,
+    objectFlatFieldMetadataMaps.byId,
   ).filter(isDefined);
 
   return {
-    objectFlatFieldMetadataById,
     objectFlatFieldMetadatas,
   };
 };

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/from-delete-field-input-to-flat-field-metadatas-to-delete.util.ts

@@ -13,7 +13,7 @@ import {
 } from 'src/engine/metadata-modules/field-metadata/field-metadata.exception';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
 import { computeFlatFieldMetadataRelatedFlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/utils/compute-flat-field-metadata-related-flat-field-metadata.util';
-import { findObjectFieldsInFlatFieldMetadataMapsOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util';
+import { findObjectFlatFieldMetadatasOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util';
 import { type FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-metadata/types/flat-index-metadata.type';
 import { generateFlatIndexMetadataWithNameOrThrow } from 'src/engine/metadata-modules/index-metadata/utils/generate-flat-index.util';
 
@@ -140,11 +140,10 @@ export const fromDeleteFieldInputToFlatFieldMetadatasToDelete = ({
         flatEntityMaps: existingFlatObjectMetadataMaps,
         flatEntityId: flatIndex.objectMetadataId,
       });
-      const { objectFlatFieldMetadatas } =
-        findObjectFieldsInFlatFieldMetadataMapsOrThrow({
-          flatFieldMetadataMaps: existingFlatFieldMetadataMaps,
-          flatObjectMetadata,
-        });
+      const { objectFlatFieldMetadatas } = findObjectFlatFieldMetadatasOrThrow({
+        flatFieldMetadataMaps: existingFlatFieldMetadataMaps,
+        flatObjectMetadata,
+      });
 
       const newIndex = generateFlatIndexMetadataWithNameOrThrow({
         flatObjectMetadata,

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/recompute-index-on-flat-field-metadata-name-update.util.ts

@@ -2,7 +2,7 @@ import { isDefined } from 'twenty-shared/utils';
 
 import { type AllFlatEntityMaps } from 'src/engine/core-modules/common/types/all-flat-entity-maps.type';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { findObjectFieldsInFlatFieldMetadataMapsOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util';
+import { findObjectFlatFieldMetadatasOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-object-fields-in-flat-field-metadata-maps-or-throw.util';
 import { type FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-metadata/types/flat-index-metadata.type';
 import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
 import { generateFlatIndexMetadataWithNameOrThrow } from 'src/engine/metadata-modules/index-metadata/utils/generate-flat-index.util';
@@ -35,11 +35,10 @@ export const recomputeIndexOnFlatFieldMetadataNameUpdate = ({
     return [];
   }
 
-  const { objectFlatFieldMetadatas } =
-    findObjectFieldsInFlatFieldMetadataMapsOrThrow({
-      flatFieldMetadataMaps,
-      flatObjectMetadata,
-    });
+  const { objectFlatFieldMetadatas } = findObjectFlatFieldMetadatasOrThrow({
+    flatFieldMetadataMaps,
+    flatObjectMetadata,
+  });
   const optimisticObjectFlatFieldMetadatas = objectFlatFieldMetadatas.map(
     (flatFieldMetadata) => {
       if (flatFieldMetadata.id === fromFlatFieldMetadata.id) {