Setup relations for remote objects (#5149)

New strategy:
- add settings field on FieldMetadata. Contains a boolean isIdField and
for numbers, a precision
- if idField, the graphql scalar returned will be a GraphQL id. This
will allow the app to work even for ids that are not uuid
- remove globals dateScalar and numberScalar modes. These were not used
- set limit as Integer
- check manually in query runner mutations that we send a valid id

Todo left:
- remove WorkspaceBuildSchemaOptions since this is not used anymore.
Will do in another PR

---------

Co-authored-by: Thomas Trompette <thomast@twenty.com>
Co-authored-by: Weiko <corentin@twenty.com>

packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/services/type-mapper.service.ts

@@ -1,10 +1,11 @@
 import { Injectable } from '@nestjs/common';
-import { GraphQLISODateTime, GraphQLTimestamp } from '@nestjs/graphql';
+import { GraphQLISODateTime } from '@nestjs/graphql';
 
 import {
   GraphQLBoolean,
   GraphQLEnumType,
   GraphQLFloat,
+  GraphQLID,
   GraphQLInputObjectType,
   GraphQLInputType,
   GraphQLInt,
@@ -15,22 +16,17 @@ import {
   GraphQLType,
 } from 'graphql';
 
-import {
-  DateScalarMode,
-  NumberScalarMode,
-} from 'src/engine/api/graphql/workspace-schema-builder/interfaces/workspace-build-schema-optionts.interface';
+import { FieldMetadataSettings } from 'src/engine/metadata-modules/field-metadata/interfaces/field-metadata-settings.interface';
 
 import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
 import {
-  UUIDFilterType,
   StringFilterType,
-  DatetimeFilterType,
   DateFilterType,
   FloatFilterType,
-  IntFilterType,
   BooleanFilterType,
   BigFloatFilterType,
   RawJsonFilterType,
+  IntFilterType,
 } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/input';
 import { OrderByDirectionType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/enum';
 import {
@@ -39,38 +35,46 @@ import {
 } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
 import { PositionScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars/position.scalar';
 import { JsonScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars/json.scalar';
+import { IDFilterType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/input/id-filter.input-type';
 
 export interface TypeOptions<T = any> {
   nullable?: boolean;
   isArray?: boolean;
   arrayDepth?: number;
   defaultValue?: T;
+  settings?: FieldMetadataSettings<FieldMetadataType | 'default'>;
+  isIdField?: boolean;
 }
 
 @Injectable()
 export class TypeMapperService {
   mapToScalarType(
     fieldMetadataType: FieldMetadataType,
-    dateScalarMode: DateScalarMode = 'isoDate',
-    numberScalarMode: NumberScalarMode = 'float',
+    settings?: FieldMetadataSettings<FieldMetadataType | 'default'>,
+    isIdField?: boolean,
   ): GraphQLScalarType | undefined {
-    const dateScalar =
-      dateScalarMode === 'timestamp' ? GraphQLTimestamp : GraphQLISODateTime;
+    if (isIdField || settings?.isForeignKey) {
+      return GraphQLID;
+    }
+
     const numberScalar =
-      numberScalarMode === 'float' ? GraphQLFloat : GraphQLInt;
+      fieldMetadataType === FieldMetadataType.NUMBER &&
+      (settings as FieldMetadataSettings<FieldMetadataType.NUMBER>)
+        ?.precision === 0
+        ? GraphQLInt
+        : GraphQLFloat;
 
     const typeScalarMapping = new Map<FieldMetadataType, GraphQLScalarType>([
       [FieldMetadataType.UUID, UUIDScalarType],
       [FieldMetadataType.TEXT, GraphQLString],
       [FieldMetadataType.PHONE, GraphQLString],
       [FieldMetadataType.EMAIL, GraphQLString],
-      [FieldMetadataType.DATE_TIME, dateScalar],
-      [FieldMetadataType.DATE, dateScalar],
+      [FieldMetadataType.DATE_TIME, GraphQLISODateTime],
+      [FieldMetadataType.DATE, GraphQLISODateTime],
       [FieldMetadataType.BOOLEAN, GraphQLBoolean],
       [FieldMetadataType.NUMBER, numberScalar],
       [FieldMetadataType.NUMERIC, BigFloatScalarType],
       [FieldMetadataType.PROBABILITY, GraphQLFloat],
-      [FieldMetadataType.RELATION, UUIDScalarType],
       [FieldMetadataType.POSITION, PositionScalarType],
       [FieldMetadataType.RAW_JSON, JsonScalarType],
     ]);
@@ -80,29 +84,34 @@ export class TypeMapperService {
 
   mapToFilterType(
     fieldMetadataType: FieldMetadataType,
-    dateScalarMode: DateScalarMode = 'isoDate',
-    numberScalarMode: NumberScalarMode = 'float',
+    settings?: FieldMetadataSettings<FieldMetadataType | 'default'>,
+    isIdField?: boolean,
   ): GraphQLInputObjectType | GraphQLScalarType | undefined {
-    const dateFilter =
-      dateScalarMode === 'timestamp' ? DatetimeFilterType : DateFilterType;
+    if (isIdField || settings?.isForeignKey) {
+      return IDFilterType;
+    }
+
     const numberScalar =
-      numberScalarMode === 'float' ? FloatFilterType : IntFilterType;
+      fieldMetadataType === FieldMetadataType.NUMBER &&
+      (settings as FieldMetadataSettings<FieldMetadataType.NUMBER>)
+        ?.precision === 0
+        ? IntFilterType
+        : FloatFilterType;
 
     const typeFilterMapping = new Map<
       FieldMetadataType,
       GraphQLInputObjectType | GraphQLScalarType
     >([
-      [FieldMetadataType.UUID, UUIDFilterType],
+      [FieldMetadataType.UUID, IDFilterType],
       [FieldMetadataType.TEXT, StringFilterType],
       [FieldMetadataType.PHONE, StringFilterType],
       [FieldMetadataType.EMAIL, StringFilterType],
-      [FieldMetadataType.DATE_TIME, dateFilter],
+      [FieldMetadataType.DATE_TIME, DateFilterType],
       [FieldMetadataType.DATE, DateFilterType],
       [FieldMetadataType.BOOLEAN, BooleanFilterType],
       [FieldMetadataType.NUMBER, numberScalar],
       [FieldMetadataType.NUMERIC, BigFloatFilterType],
       [FieldMetadataType.PROBABILITY, FloatFilterType],
-      [FieldMetadataType.RELATION, UUIDFilterType],
       [FieldMetadataType.POSITION, FloatFilterType],
       [FieldMetadataType.RAW_JSON, RawJsonFilterType],
     ]);