houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Relation field metadata strict validation (#16890)

Browse Source 
# Introduction

Now validating relation related object and field foreignkey integrity
This commit is contained in:
Paul Rastoin
2026-01-01 15:09:48 +01:00
committed by GitHub
parent dff5e3cd7b
commit 1d9eb07ee0
3 changed files with 751 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-morph-or-relation-flat-field-metadata.util.ts
+45 -7
View File
@@ -73,13 +73,51 @@ export const validateMorphOrRelationFlatFieldMetadata = ({
: 'Relation field target metadata not found',
userFriendlyMessage: msg`Relation field target metadata not found`,
});
} else if (!isMorphOrRelationFlatFieldMetadata(targetFlatFieldMetadata)) {
errors.push({
code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
message:
'A relation field can only target a MORPH_RELATION or another RELATION field',
userFriendlyMessage: msg`Invalid relation field target`,
});
} else {
if (!isMorphOrRelationFlatFieldMetadata(targetFlatFieldMetadata)) {
errors.push({
code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
message:
'A relation field can only target a MORPH_RELATION or another RELATION field',
userFriendlyMessage: msg`Invalid relation field target`,
});
} else {
if (
targetFlatFieldMetadata.objectMetadataId !==
flatFieldMetadataToValidate.relationTargetObjectMetadataId
) {
errors.push({
code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
message:
'Target field metadata does not belong to the expected target object',
userFriendlyMessage: msg`Target relation field does not belong to the expected object`,
});
}
if (
targetFlatFieldMetadata.relationTargetObjectMetadataId !==
flatFieldMetadataToValidate.objectMetadataId
) {
errors.push({
code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
message:
'Target field metadata does not point back to the source object',
userFriendlyMessage: msg`Target relation field does not reference the source object`,
});
}
if (
targetFlatFieldMetadata.relationTargetFieldMetadataId !==
flatFieldMetadataToValidate.id
) {
errors.push({
code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
message:
'Target field metadata does not point back to the source field',
userFriendlyMessage: msg`Target relation field does not reference this field`,
});
}
}
}
if (