clean searchResolvers in server (#11114)

Introduces break in change - remove search... resolvers - rename globalSearch to search - rename searchRecord.objectSingularName > objectNameSingular closes https://github.com/twentyhq/core-team-issues/issues/643
2025-03-24 13:42:51 +01:00
parent 6e7d2db58f
commit 1c5f3ef5fa
52 changed files with 236 additions and 529 deletions
@@ -2,7 +2,6 @@ export const RESOLVER_METHOD_NAMES = {
  FIND_MANY: 'findMany',
  FIND_ONE: 'findOne',
  FIND_DUPLICATES: 'findDuplicates',
-  SEARCH: 'search',
  CREATE_MANY: 'createMany',
  CREATE_ONE: 'createOne',
  UPDATE_MANY: 'updateMany',
@@ -2,7 +2,6 @@ import { DestroyManyResolverFactory } from 'src/engine/api/graphql/workspace-res
 import { DestroyOneResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/destroy-one-resolver.factory';
 import { RestoreManyResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/restore-many-resolver.factory';
 import { RestoreOneResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/restore-one-resolver.factory';
-import { SearchResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/search-resolver-factory';
 import { UpdateManyResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/update-many-resolver.factory';

 import { CreateManyResolverFactory } from './create-many-resolver.factory';
@@ -28,7 +27,6 @@ export const workspaceResolverBuilderFactories = [
  DestroyManyResolverFactory,
  RestoreOneResolverFactory,
  RestoreManyResolverFactory,
-  SearchResolverFactory,
 ];

 export const workspaceResolverBuilderMethodNames = {
@@ -36,7 +34,6 @@ export const workspaceResolverBuilderMethodNames = {
    FindManyResolverFactory.methodName,
    FindOneResolverFactory.methodName,
    FindDuplicatesResolverFactory.methodName,
-    SearchResolverFactory.methodName,
  ],
  mutations: [
    CreateManyResolverFactory.methodName,
@@ -1,43 +0,0 @@
-import { Injectable } from '@nestjs/common';
-
-import { WorkspaceQueryRunnerOptions } from 'src/engine/api/graphql/workspace-query-runner/interfaces/query-runner-option.interface';
-import { WorkspaceResolverBuilderFactoryInterface } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolver-builder-factory.interface';
-import {
-  Resolver,
-  SearchResolverArgs,
-} from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
-import { WorkspaceSchemaBuilderContext } from 'src/engine/api/graphql/workspace-schema-builder/interfaces/workspace-schema-builder-context.interface';
-
-import { GraphqlQuerySearchResolverService } from 'src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-search-resolver.service';
-import { RESOLVER_METHOD_NAMES } from 'src/engine/api/graphql/workspace-resolver-builder/constants/resolver-method-names';
-
-@Injectable()
-export class SearchResolverFactory
-  implements WorkspaceResolverBuilderFactoryInterface
-{
-  public static methodName = RESOLVER_METHOD_NAMES.SEARCH;
-
-  constructor(
-    private readonly graphqlQueryRunnerService: GraphqlQuerySearchResolverService,
-  ) {}
-
-  create(context: WorkspaceSchemaBuilderContext): Resolver<SearchResolverArgs> {
-    const internalContext = context;
-
-    return async (_source, args, _context, info) => {
-      const options: WorkspaceQueryRunnerOptions = {
-        authContext: internalContext.authContext,
-        info,
-        objectMetadataMaps: internalContext.objectMetadataMaps,
-        objectMetadataItemWithFieldMaps:
-          internalContext.objectMetadataItemWithFieldMaps,
-      };
-
-      return await this.graphqlQueryRunnerService.execute(
-        args,
-        options,
-        SearchResolverFactory.methodName,
-      );
-    };
-  }
-}
@@ -48,14 +48,6 @@ export interface FindDuplicatesResolverArgs<
  data?: Data[];
 }

-export interface SearchResolverArgs<
-  Filter extends ObjectRecordFilter = ObjectRecordFilter,
-> {
-  searchInput?: string;
-  filter?: Filter;
-  limit?: number;
-}
-
 export interface CreateOneResolverArgs<
  Data extends Partial<ObjectRecord> = Partial<ObjectRecord>,
 > {
@@ -135,6 +127,5 @@ export type ResolverArgs =
  | FindOneResolverArgs
  | RestoreManyResolverArgs
  | RestoreOneResolverArgs
-  | SearchResolverArgs
  | UpdateManyResolverArgs
  | UpdateOneResolverArgs;
@@ -6,7 +6,6 @@ import { WorkspaceResolverBuilderMethodNames } from 'src/engine/api/graphql/work
 import { ObjectMetadataInterface } from 'src/engine/metadata-modules/field-metadata/interfaces/object-metadata.interface';

 import { FindDuplicatesResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/find-duplicates-resolver.factory';
-import { SearchResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/search-resolver-factory';

@Injectable()
 export class WorkspaceResolverBuilderService {
@@ -19,8 +18,6 @@ export class WorkspaceResolverBuilderService {
    switch (methodName) {
      case FindDuplicatesResolverFactory.methodName:
        return isDefined(objectMetadata.duplicateCriteria);
-      case SearchResolverFactory.methodName:
-        return objectMetadata.isSearchable;
      default:
        return true;
    }
@@ -7,7 +7,6 @@ import { DestroyManyResolverFactory } from 'src/engine/api/graphql/workspace-res
 import { DestroyOneResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/destroy-one-resolver.factory';
 import { RestoreManyResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/restore-many-resolver.factory';
 import { RestoreOneResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/restore-one-resolver.factory';
-import { SearchResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/search-resolver-factory';
 import { UpdateManyResolverFactory } from 'src/engine/api/graphql/workspace-resolver-builder/factories/update-many-resolver.factory';
 import { WorkspaceResolverBuilderService } from 'src/engine/api/graphql/workspace-resolver-builder/workspace-resolver-builder.service';
 import { AuthContext } from 'src/engine/core-modules/auth/types/auth-context.type';
@@ -45,7 +44,6 @@ export class WorkspaceResolverFactory {
    private readonly restoreOneResolverFactory: RestoreOneResolverFactory,
    private readonly restoreManyResolverFactory: RestoreManyResolverFactory,
    private readonly destroyManyResolverFactory: DestroyManyResolverFactory,
-    private readonly searchResolverFactory: SearchResolverFactory,
    private readonly workspaceResolverBuilderService: WorkspaceResolverBuilderService,
  ) {}

@@ -69,7 +67,6 @@ export class WorkspaceResolverFactory {
      ['findOne', this.findOneResolverFactory],
      ['restoreMany', this.restoreManyResolverFactory],
      ['restoreOne', this.restoreOneResolverFactory],
-      ['search', this.searchResolverFactory],
      ['updateMany', this.updateManyResolverFactory],
      ['updateOne', this.updateOneResolverFactory],
    ]);