Fix v2 self relation field creation (#15382)

# Introduction
Fixing self relation field creation in v2
- When computing related flat field to delete on object metadata
deletion that has self relation fields
- On self relation creation validation name availability not searching
for the relation target field of the current object field if it's the
field being validated

## Coverage
- added CUD integration testing on self relation fields

close https://github.com/twentyhq/twenty/issues/15153

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-relation-properties-to-compare.constant.ts

@@ -5,4 +5,5 @@ export const FLAT_FIELD_METADATA_RELATION_PROPERTIES_TO_COMPARE = [
   'description',
   'isActive',
   'standardOverrides',
+  'icon',
 ] as const satisfies (typeof ALL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY.fieldMetadata.propertiesToCompare)[number][];

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-flat-field-metadata-name-availability.util.ts

@@ -79,13 +79,17 @@ export const validateFlatFieldMetadataNameAvailability = ({
       }
 
       const targetFlatFieldMetadata =
-        remainingFlatEntityMapsToValidate?.byId[
-          existingFlatFieldMetadata.relationTargetFieldMetadataId
-        ] ??
-        findFlatEntityByIdInFlatEntityMapsOrThrow({
-          flatEntityId: existingFlatFieldMetadata.relationTargetFieldMetadataId,
-          flatEntityMaps: flatFieldMetadataMaps,
-        });
+        flatFieldMetadata.id ===
+        existingFlatFieldMetadata.relationTargetFieldMetadataId
+          ? flatFieldMetadata
+          : (remainingFlatEntityMapsToValidate?.byId[
+              existingFlatFieldMetadata.relationTargetFieldMetadataId
+            ] ??
+            findFlatEntityByIdInFlatEntityMapsOrThrow({
+              flatEntityId:
+                existingFlatFieldMetadata.relationTargetFieldMetadataId,
+              flatEntityMaps: flatFieldMetadataMaps,
+            }));
 
       if (!isMorphOrRelationFlatFieldMetadata(targetFlatFieldMetadata)) {
         return false;

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-delete-object-input-to-flat-field-metadatas-to-delete.util.ts

@@ -59,7 +59,11 @@ export const fromDeleteObjectInputToFlatFieldMetadatasToDelete = ({
     });
   const flatFieldMetadatasToDelete = objectFlatFieldMetadatas.flatMap(
     (flatFieldMetadata) => {
-      if (isMorphOrRelationFlatFieldMetadata(flatFieldMetadata)) {
+      if (
+        isMorphOrRelationFlatFieldMetadata(flatFieldMetadata) &&
+        flatFieldMetadata.relationTargetObjectMetadataId !==
+          objectMetadataToDeleteId
+      ) {
         const relationTargetFlatFieldMetadata =
           findRelationFlatFieldMetadataTargetFlatFieldMetadataOrThrow({
             flatFieldMetadata,