File - Migrate core pictures (workspace and member logo) + workflow attachments (#17924)

- Create a common file-by-id download controller
- Create core picture module with resolver and logic to handle
workspaceLogo and workspaceMemberProfilePicture update
- Create workflow file module (same)
- Data migration

packages/twenty-server/src/engine/core-modules/tool/tool.module.ts

@@ -1,6 +1,7 @@
 import { Module } from '@nestjs/common';
 import { TypeOrmModule } from '@nestjs/typeorm';
 
+import { FeatureFlagModule } from 'src/engine/core-modules/feature-flag/feature-flag.module';
 import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
 import { FileModule } from 'src/engine/core-modules/file/file.module';
 import { JwtModule } from 'src/engine/core-modules/jwt/jwt.module';
@@ -19,6 +20,7 @@ import { MessagingSendManagerModule } from 'src/modules/messaging/message-outbou
     MessagingImportManagerModule,
     MessagingSendManagerModule,
     TypeOrmModule.forFeature([FileEntity]),
+    FeatureFlagModule,
     FileModule,
     JwtModule,
     SecureHttpClientModule,

packages/twenty-server/src/engine/core-modules/tool/tools/code-interpreter-tool/code-interpreter-tool.ts

@@ -7,8 +7,8 @@ import {
   type CodeExecutionFile,
   type CodeExecutionState,
 } from 'twenty-shared/ai';
-import { v4 } from 'uuid';
 import { FileFolder } from 'twenty-shared/types';
+import { v4 } from 'uuid';
 
 import {
   type InputFile,

packages/twenty-server/src/engine/core-modules/tool/tools/email-tool/email-composer.service.ts

@@ -1,17 +1,23 @@
 import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 
+import { Readable } from 'stream';
+
 import { render, toPlainText } from '@react-email/render';
 import DOMPurify from 'dompurify';
 import { reactMarkupFromJSON } from 'twenty-emails';
+import { FileFolder } from 'twenty-shared/types';
 import {
   extractFolderPathFilenameAndTypeOrThrow,
   isDefined,
   isValidUuid,
 } from 'twenty-shared/utils';
+import { WorkflowAttachment } from 'twenty-shared/workflow';
 import { In, type Repository } from 'typeorm';
 import { z } from 'zod';
 
+import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
+import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
 import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
 import { FileService } from 'src/engine/core-modules/file/services/file.service';
 import {
@@ -40,8 +46,16 @@ export class EmailComposerService {
     @InjectRepository(FileEntity)
     private readonly fileRepository: Repository<FileEntity>,
     private readonly fileService: FileService,
+    private readonly featureFlagService: FeatureFlagService,
   ) {}
 
+  private async isOtherFileMigrated(workspaceId: string): Promise<boolean> {
+    return this.featureFlagService.isFeatureEnabled(
+      FeatureFlagKey.IS_OTHER_FILE_MIGRATED,
+      workspaceId,
+    );
+  }
+
   private async getConnectedAccount(
     connectedAccountId: string,
     workspaceId: string,
@@ -166,7 +180,7 @@ export class EmailComposerService {
   }
 
   private async getAttachments(
-    files: Array<{ id: string; name: string; type: string }>,
+    files: Array<WorkflowAttachment>,
     workspaceId: string,
   ): Promise<MessageAttachment[]> {
     if (files.length === 0) {
@@ -207,11 +221,23 @@ export class EmailComposerService {
         fileEntity.path,
       );
 
-      const stream = await this.fileService.getFileStream(
-        folderPath,
-        filename,
-        workspaceId,
-      );
+      const isOtherFileMigrated = await this.isOtherFileMigrated(workspaceId);
+
+      let stream: Readable;
+
+      if (isOtherFileMigrated) {
+        stream = await this.fileService.getFileStreamById({
+          fileId: fileMetadata.id,
+          workspaceId,
+          fileFolder: FileFolder.Workflow,
+        });
+      } else {
+        stream = await this.fileService.getFileStream(
+          folderPath,
+          filename,
+          workspaceId,
+        );
+      }
 
       const buffer = await streamToBuffer(stream);