From 1113c20d89725961e46350608fcae5791058fa2e Mon Sep 17 00:00:00 2001
From: BOHEUS <56270748+BOHEUS@users.noreply.github.com>
Date: Tue, 6 Jan 2026 16:00:10 +0000
Subject: [PATCH] Destroy core view (#16868)

Solution for #16526

---------

Co-authored-by: prastoin <paul@twenty.com>
---
 .../ObjectOptionsDropdownCustomView.tsx        |  6 +++---
 .../views/hooks/internal/usePersistView.ts     | 18 +++++++++---------
 .../components/ViewPickerCreateButton.tsx      |  6 +++---
 .../components/ViewPickerEditButton.tsx        |  6 +++---
 .../components/ViewPickerOptionDropdown.tsx    |  6 +++---
 ...te.ts => useDestroyViewFromCurrentState.ts} | 12 ++++++------
 6 files changed, 27 insertions(+), 27 deletions(-)
 rename packages/twenty-front/src/modules/views/view-picker/hooks/{useDeleteViewFromCurrentState.ts => useDestroyViewFromCurrentState.ts} (91%)

diff --git a/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownCustomView.tsx b/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownCustomView.tsx
index f67c55ca33..dc997edb0f 100644
--- a/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownCustomView.tsx
+++ b/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownCustomView.tsx
@@ -16,7 +16,7 @@ import { useSetRecoilComponentState } from '@/ui/utilities/state/component-state
 import { useGetCurrentViewOnly } from '@/views/hooks/useGetCurrentViewOnly';
 import { ViewKey } from '@/views/types/ViewKey';
 import { ViewType, viewTypeIconMapping } from '@/views/types/ViewType';
-import { useDeleteViewFromCurrentState } from '@/views/view-picker/hooks/useDeleteViewFromCurrentState';
+import { useDestroyViewFromCurrentState } from '@/views/view-picker/hooks/useDestroyViewFromCurrentState';
 import { viewPickerReferenceViewIdComponentState } from '@/views/view-picker/states/viewPickerReferenceViewIdComponentState';
 import { useLingui } from '@lingui/react/macro';
 import { useRecoilValue } from 'recoil';
@@ -78,7 +78,7 @@ export const ObjectOptionsDropdownCustomView = ({
 
   const visibleFieldsCount = visibleBoardFields.length;
 
-  const { deleteViewFromCurrentState } = useDeleteViewFromCurrentState();
+  const { destroyViewFromCurrentState } = useDestroyViewFromCurrentState();
   const setViewPickerReferenceViewId = useSetRecoilComponentState(
     viewPickerReferenceViewIdComponentState,
   );
@@ -88,7 +88,7 @@ export const ObjectOptionsDropdownCustomView = ({
       return;
     }
     setViewPickerReferenceViewId(customViewData?.id);
-    deleteViewFromCurrentState();
+    destroyViewFromCurrentState();
     closeDropdown();
     onBackToDefault?.();
   };
diff --git a/packages/twenty-front/src/modules/views/hooks/internal/usePersistView.ts b/packages/twenty-front/src/modules/views/hooks/internal/usePersistView.ts
index f2c4c6f328..e981650a85 100644
--- a/packages/twenty-front/src/modules/views/hooks/internal/usePersistView.ts
+++ b/packages/twenty-front/src/modules/views/hooks/internal/usePersistView.ts
@@ -10,10 +10,10 @@ import { isDefined } from 'twenty-shared/utils';
 import { v4 } from 'uuid';
 import {
   type CreateCoreViewMutationVariables,
-  type DeleteCoreViewMutationVariables,
+  type DestroyCoreViewMutationVariables,
   type UpdateCoreViewMutationVariables,
   useCreateCoreViewMutation,
-  useDeleteCoreViewMutation,
+  useDestroyCoreViewMutation,
   useUpdateCoreViewMutation,
   ViewType,
 } from '~/generated/graphql';
@@ -21,7 +21,7 @@ import {
 export const usePersistView = () => {
   const [createCoreViewMutation] = useCreateCoreViewMutation();
   const [updateCoreViewMutation] = useUpdateCoreViewMutation();
-  const [deleteCoreViewMutation] = useDeleteCoreViewMutation();
+  const [destroyCoreViewMutation] = useDestroyCoreViewMutation();
   const { triggerViewGroupOptimisticEffectAtViewCreation } =
     useViewsSideEffectsOnViewGroups();
 
@@ -124,14 +124,14 @@ export const usePersistView = () => {
     [updateCoreViewMutation, handleMetadataError, enqueueErrorSnackBar],
   );
 
-  const deleteView = useCallback(
+  const destroyView = useCallback(
     async (
-      variables: DeleteCoreViewMutationVariables,
+      variables: DestroyCoreViewMutationVariables,
     ): Promise<
-      MetadataRequestResult<Awaited<ReturnType<typeof deleteCoreViewMutation>>>
+      MetadataRequestResult<Awaited<ReturnType<typeof destroyCoreViewMutation>>>
     > => {
       try {
-        const result = await deleteCoreViewMutation({
+        const result = await destroyCoreViewMutation({
           variables,
         });
 
@@ -154,12 +154,12 @@ export const usePersistView = () => {
         };
       }
     },
-    [deleteCoreViewMutation, handleMetadataError, enqueueErrorSnackBar],
+    [destroyCoreViewMutation, handleMetadataError, enqueueErrorSnackBar],
   );
 
   return {
     createView,
     updateView,
-    deleteView,
+    destroyView,
   };
 };
diff --git a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerCreateButton.tsx b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerCreateButton.tsx
index 810145338e..c58949fcf9 100644
--- a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerCreateButton.tsx
+++ b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerCreateButton.tsx
@@ -1,7 +1,7 @@
 import { useRecoilComponentValue } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValue';
 import { ViewType } from '@/views/types/ViewType';
 import { useCreateViewFromCurrentState } from '@/views/view-picker/hooks/useCreateViewFromCurrentState';
-import { useDeleteViewFromCurrentState } from '@/views/view-picker/hooks/useDeleteViewFromCurrentState';
+import { useDestroyViewFromCurrentState } from '@/views/view-picker/hooks/useDestroyViewFromCurrentState';
 import { useGetAvailableFieldsForCalendar } from '@/views/view-picker/hooks/useGetAvailableFieldsForCalendar';
 import { useGetAvailableFieldsForKanban } from '@/views/view-picker/hooks/useGetAvailableFieldsForKanban';
 import { useViewPickerMode } from '@/views/view-picker/hooks/useViewPickerMode';
@@ -32,7 +32,7 @@ export const ViewPickerCreateButton = () => {
   );
 
   const { createViewFromCurrentState } = useCreateViewFromCurrentState();
-  const { deleteViewFromCurrentState } = useDeleteViewFromCurrentState();
+  const { destroyViewFromCurrentState } = useDestroyViewFromCurrentState();
 
   const handleCreateButtonClick = () => {
     createViewFromCurrentState();
@@ -42,7 +42,7 @@ export const ViewPickerCreateButton = () => {
     return (
       <Button
         title={t`Delete`}
-        onClick={deleteViewFromCurrentState}
+        onClick={destroyViewFromCurrentState}
         accent="danger"
         fullWidth
         size="small"
diff --git a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerEditButton.tsx b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerEditButton.tsx
index 4566a1144f..c233802b28 100644
--- a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerEditButton.tsx
+++ b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerEditButton.tsx
@@ -1,7 +1,7 @@
 import { useRecoilComponentValue } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValue';
 import { ViewType } from '@/views/types/ViewType';
 import { useCreateViewFromCurrentState } from '@/views/view-picker/hooks/useCreateViewFromCurrentState';
-import { useDeleteViewFromCurrentState } from '@/views/view-picker/hooks/useDeleteViewFromCurrentState';
+import { useDestroyViewFromCurrentState } from '@/views/view-picker/hooks/useDestroyViewFromCurrentState';
 import { useGetAvailableFieldsForKanban } from '@/views/view-picker/hooks/useGetAvailableFieldsForKanban';
 import { useViewPickerMode } from '@/views/view-picker/hooks/useViewPickerMode';
 import { viewPickerIsPersistingComponentState } from '@/views/view-picker/states/viewPickerIsPersistingComponentState';
@@ -24,13 +24,13 @@ export const ViewPickerEditButton = () => {
   );
 
   const { createViewFromCurrentState } = useCreateViewFromCurrentState();
-  const { deleteViewFromCurrentState } = useDeleteViewFromCurrentState();
+  const { destroyViewFromCurrentState } = useDestroyViewFromCurrentState();
 
   if (viewPickerMode === 'edit') {
     return (
       <Button
         title={t`Delete`}
-        onClick={deleteViewFromCurrentState}
+        onClick={destroyViewFromCurrentState}
         accent="danger"
         fullWidth
         size="small"
diff --git a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx
index a788d3827f..1d7727063e 100644
--- a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx
+++ b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx
@@ -7,7 +7,7 @@ import { useCloseDropdown } from '@/ui/layout/dropdown/hooks/useCloseDropdown';
 import { MenuItemWithOptionDropdown } from '@/ui/navigation/menu-item/components/MenuItemWithOptionDropdown';
 import { useSetRecoilComponentState } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentState';
 import { type View } from '@/views/types/View';
-import { useDeleteViewFromCurrentState } from '@/views/view-picker/hooks/useDeleteViewFromCurrentState';
+import { useDestroyViewFromCurrentState } from '@/views/view-picker/hooks/useDestroyViewFromCurrentState';
 import { useViewPickerMode } from '@/views/view-picker/hooks/useViewPickerMode';
 import { viewPickerReferenceViewIdComponentState } from '@/views/view-picker/states/viewPickerReferenceViewIdComponentState';
 import { useLingui } from '@lingui/react/macro';
@@ -48,7 +48,7 @@ export const ViewPickerOptionDropdown = ({
   const { t } = useLingui();
   const { closeDropdown } = useCloseDropdown();
   const { getIcon } = useIcons();
-  const { deleteViewFromCurrentState } = useDeleteViewFromCurrentState();
+  const { destroyViewFromCurrentState } = useDestroyViewFromCurrentState();
   const setViewPickerReferenceViewId = useSetRecoilComponentState(
     viewPickerReferenceViewIdComponentState,
   );
@@ -70,7 +70,7 @@ export const ViewPickerOptionDropdown = ({
 
   const handleDelete = () => {
     setViewPickerReferenceViewId(view.id);
-    deleteViewFromCurrentState();
+    destroyViewFromCurrentState();
     closeDropdown(dropdownId);
   };
 
diff --git a/packages/twenty-front/src/modules/views/view-picker/hooks/useDeleteViewFromCurrentState.ts b/packages/twenty-front/src/modules/views/view-picker/hooks/useDestroyViewFromCurrentState.ts
similarity index 91%
rename from packages/twenty-front/src/modules/views/view-picker/hooks/useDeleteViewFromCurrentState.ts
rename to packages/twenty-front/src/modules/views/view-picker/hooks/useDestroyViewFromCurrentState.ts
index 79c575871c..01ae7e5606 100644
--- a/packages/twenty-front/src/modules/views/view-picker/hooks/useDeleteViewFromCurrentState.ts
+++ b/packages/twenty-front/src/modules/views/view-picker/hooks/useDestroyViewFromCurrentState.ts
@@ -13,7 +13,7 @@ import { viewPickerIsDirtyComponentState } from '@/views/view-picker/states/view
 import { viewPickerIsPersistingComponentState } from '@/views/view-picker/states/viewPickerIsPersistingComponentState';
 import { viewPickerReferenceViewIdComponentState } from '@/views/view-picker/states/viewPickerReferenceViewIdComponentState';
 
-export const useDeleteViewFromCurrentState = (viewBarInstanceId?: string) => {
+export const useDestroyViewFromCurrentState = (viewBarInstanceId?: string) => {
   const { closeAndResetViewPicker } = useCloseAndResetViewPicker();
 
   const viewPickerIsPersistingCallbackState = useRecoilComponentCallbackState(
@@ -44,9 +44,9 @@ export const useDeleteViewFromCurrentState = (viewBarInstanceId?: string) => {
 
   const { changeView } = useChangeView();
 
-  const { deleteView } = usePersistView();
+  const { destroyView } = usePersistView();
 
-  const deleteViewFromCurrentState = useRecoilCallback(
+  const destroyViewFromCurrentState = useRecoilCallback(
     ({ set, snapshot }) =>
       async () => {
         set(viewPickerIsPersistingCallbackState, true);
@@ -74,14 +74,14 @@ export const useDeleteViewFromCurrentState = (viewBarInstanceId?: string) => {
             views.filter((view) => view.id !== viewPickerReferenceViewId),
         );
 
-        await deleteView({ id: viewPickerReferenceViewId });
+        await destroyView({ id: viewPickerReferenceViewId });
       },
     [
       currentView,
       closeAndResetViewPicker,
       objectMetadataItem.id,
       changeView,
-      deleteView,
+      destroyView,
       viewPickerIsDirtyCallbackState,
       viewPickerIsPersistingCallbackState,
       viewPickerReferenceViewIdCallbackState,
@@ -90,6 +90,6 @@ export const useDeleteViewFromCurrentState = (viewBarInstanceId?: string) => {
   );
 
   return {
-    deleteViewFromCurrentState,
+    destroyViewFromCurrentState,
   };
 };