feat: add lingui/no-unlocalized-strings ESLint rule and fix translations (#16610)
## Summary
This PR adds the `lingui/no-unlocalized-strings` ESLint rule to detect
untranslated strings and fixes translation issues across multiple
components.
## Changes
### ESLint Configuration (`eslint.config.react.mjs`)
- Added comprehensive `ignore` patterns for non-translatable strings
(CSS values, HTML attributes, technical identifiers)
- Added `ignoreNames` for props that don't need translation (className,
data-*, aria-*, etc.)
- Added `ignoreFunctions` for console methods, URL APIs, and other
non-user-facing functions
- Disabled rule for debug files, storybook, and test files
### Components Fixed (~19 files)
- Object record components (field inputs, pickers, merge dialogs)
- Settings components (accounts, admin panel)
- Serverless function components
- Record table and title cell components
## Status
🚧 **Work in Progress** - ~124 files remaining to fix
This PR is being submitted as draft to allow progressive fixing of
remaining translation issues.
## Testing
- Run `npx eslint "src/**/*.tsx"` in `packages/twenty-front` to check
remaining issues
This commit is contained in:
+5
-3
@@ -3,6 +3,7 @@ import { DropdownContent } from '@/ui/layout/dropdown/components/DropdownContent
|
||||
import { DropdownMenuItemsContainer } from '@/ui/layout/dropdown/components/DropdownMenuItemsContainer';
|
||||
import { GenericDropdownContentWidth } from '@/ui/layout/dropdown/constants/GenericDropdownContentWidth';
|
||||
import { useCloseDropdown } from '@/ui/layout/dropdown/hooks/useCloseDropdown';
|
||||
import { useLingui } from '@lingui/react/macro';
|
||||
import {
|
||||
IconDotsVertical,
|
||||
IconDownload,
|
||||
@@ -27,6 +28,7 @@ export const AttachmentDropdown = ({
|
||||
attachmentId,
|
||||
hasDownloadPermission,
|
||||
}: AttachmentDropdownProps) => {
|
||||
const { t } = useLingui();
|
||||
const dropdownId = `${attachmentId}-attachment-dropdown`;
|
||||
|
||||
const { closeDropdown } = useCloseDropdown();
|
||||
@@ -57,18 +59,18 @@ export const AttachmentDropdown = ({
|
||||
<DropdownMenuItemsContainer>
|
||||
{hasDownloadPermission && (
|
||||
<MenuItem
|
||||
text="Download"
|
||||
text={t`Download`}
|
||||
LeftIcon={IconDownload}
|
||||
onClick={handleDownload}
|
||||
/>
|
||||
)}
|
||||
<MenuItem
|
||||
text="Rename"
|
||||
text={t`Rename`}
|
||||
LeftIcon={IconPencil}
|
||||
onClick={handleRename}
|
||||
/>
|
||||
<MenuItem
|
||||
text="Delete"
|
||||
text={t`Delete`}
|
||||
accent="danger"
|
||||
LeftIcon={IconTrash}
|
||||
onClick={handleDelete}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import styled from '@emotion/styled';
|
||||
import { t } from '@lingui/core/macro';
|
||||
import { lazy, type ReactElement, Suspense, useState } from 'react';
|
||||
import { createPortal } from 'react-dom';
|
||||
|
||||
@@ -240,7 +241,7 @@ export const AttachmentList = ({
|
||||
fallback={
|
||||
<StyledLoadingContainer>
|
||||
<StyledLoadingText>
|
||||
Loading document viewer...
|
||||
{t`Loading document viewer...`}
|
||||
</StyledLoadingText>
|
||||
</StyledLoadingContainer>
|
||||
}
|
||||
|
||||
@@ -6,7 +6,7 @@ import DocViewer, { DocViewerRenderers } from '@cyntler/react-doc-viewer';
|
||||
import '@cyntler/react-doc-viewer/dist/index.css';
|
||||
import { useTheme } from '@emotion/react';
|
||||
import styled from '@emotion/styled';
|
||||
import { Trans } from '@lingui/react/macro';
|
||||
import { Trans, useLingui } from '@lingui/react/macro';
|
||||
import { useEffect, useState } from 'react';
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { IconDownload } from 'twenty-ui/display';
|
||||
@@ -99,6 +99,7 @@ export const DocumentViewer = ({
|
||||
documentName,
|
||||
documentUrl,
|
||||
}: DocumentViewerProps) => {
|
||||
const { t } = useLingui();
|
||||
const theme = useTheme();
|
||||
const [csvPreview, setCsvPreview] = useState<string | undefined>(undefined);
|
||||
|
||||
@@ -141,7 +142,7 @@ export const DocumentViewer = ({
|
||||
</StyledMessage>
|
||||
<Button
|
||||
Icon={IconDownload}
|
||||
title="Download File"
|
||||
title={t`Download File`}
|
||||
onClick={() => downloadFile(documentUrl, documentName)}
|
||||
variant="secondary"
|
||||
/>
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import { useTheme } from '@emotion/react';
|
||||
import styled from '@emotion/styled';
|
||||
import { useLingui } from '@lingui/react/macro';
|
||||
import { useDropzone } from 'react-dropzone';
|
||||
|
||||
import { useSpreadsheetImportInternal } from '@/spreadsheet-import/hooks/useSpreadsheetImportInternal';
|
||||
@@ -47,6 +48,7 @@ export const DropZone = ({
|
||||
setIsDraggingFile,
|
||||
onUploadFiles,
|
||||
}: DropZoneProps) => {
|
||||
const { t } = useLingui();
|
||||
const theme = useTheme();
|
||||
const { maxFileSize } = useSpreadsheetImportInternal();
|
||||
|
||||
@@ -85,9 +87,9 @@ export const DropZone = ({
|
||||
stroke={theme.icon.stroke.sm}
|
||||
size={theme.icon.size.lg}
|
||||
/>
|
||||
<StyledUploadDragTitle>Upload files</StyledUploadDragTitle>
|
||||
<StyledUploadDragTitle>{t`Upload files`}</StyledUploadDragTitle>
|
||||
<StyledUploadDragSubTitle>
|
||||
Drag and Drop Here
|
||||
{t`Drag and Drop Here`}
|
||||
</StyledUploadDragSubTitle>
|
||||
</>
|
||||
)}
|
||||
|
||||
Reference in New Issue
Block a user