From 102b49f9196271fe18dc556e1ce6f3566d7949d8 Mon Sep 17 00:00:00 2001 From: Abdul Rahman <81605929+abdulrahmancodes@users.noreply.github.com> Date: Thu, 12 Mar 2026 02:05:15 +0530 Subject: [PATCH] Fix new navbar item position after reordering existing items (#18516) Closes [#2296](https://github.com/twentyhq/core-team-issues/issues/2296) --- .../utils/computeInsertIndexAndPosition.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/twenty-front/src/modules/navigation-menu-item/utils/computeInsertIndexAndPosition.ts b/packages/twenty-front/src/modules/navigation-menu-item/utils/computeInsertIndexAndPosition.ts index ded69167b2..87486681c0 100644 --- a/packages/twenty-front/src/modules/navigation-menu-item/utils/computeInsertIndexAndPosition.ts +++ b/packages/twenty-front/src/modules/navigation-menu-item/utils/computeInsertIndexAndPosition.ts @@ -6,11 +6,13 @@ export const computeInsertIndexAndPosition = ( targetFolderId: string | null, targetIndex: number, ) => { - const itemsInFolder = currentDraft.filter( - (item) => - (item.folderId ?? null) === targetFolderId && - !isDefined(item.userWorkspaceId), - ); + const itemsInFolder = currentDraft + .filter( + (item) => + (item.folderId ?? null) === targetFolderId && + !isDefined(item.userWorkspaceId), + ) + .sort((a, b) => a.position - b.position); const insertRef = itemsInFolder[targetIndex]; const lastInFolder = itemsInFolder[itemsInFolder.length - 1]; const flatIndex = isDefined(insertRef)