From 0ff9e77fd34e9cc566cf3e77c3d4300af8b05e30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?= <71827178+bosiraphael@users.noreply.github.com> Date: Thu, 30 Jul 2026 14:30:10 +0200 Subject: [PATCH] Hide app record-selection commands when all records are selected (#23561) PDL enrichment and call-recorder's call summary are `RECORD_SELECTION` commands backed by headless front components, which only receive record ids in selection mode. Under select all the context store switches to exclusion mode, so they received an empty `recordIds` array and still reported success while enriching nothing. They now declare `conditionalAvailabilityExpression: !isSelectAll`, so they disappear from the command menu and quick actions while select all is active. Both app versions are bumped since the server rejects redeploying an equal version. Review in cubic --- packages/twenty-apps/public/call-recorder/package.json | 2 +- .../src/command-menu-items/generate-call-recording-summary.ts | 2 ++ packages/twenty-apps/public/people-data-labs/package.json | 2 +- .../src/command-menu-items/enrich-companies.ts | 3 ++- .../people-data-labs/src/command-menu-items/enrich-people.ts | 3 ++- 5 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/twenty-apps/public/call-recorder/package.json b/packages/twenty-apps/public/call-recorder/package.json index 550ae27ec5..101036c290 100644 --- a/packages/twenty-apps/public/call-recorder/package.json +++ b/packages/twenty-apps/public/call-recorder/package.json @@ -1,6 +1,6 @@ { "name": "@twentyhq/call-recorder", - "version": "1.5.0", + "version": "1.5.1", "license": "MIT", "engines": { "node": "^24.5.0", diff --git a/packages/twenty-apps/public/call-recorder/src/command-menu-items/generate-call-recording-summary.ts b/packages/twenty-apps/public/call-recorder/src/command-menu-items/generate-call-recording-summary.ts index 9d5502fcfa..1275c3ce24 100644 --- a/packages/twenty-apps/public/call-recorder/src/command-menu-items/generate-call-recording-summary.ts +++ b/packages/twenty-apps/public/call-recorder/src/command-menu-items/generate-call-recording-summary.ts @@ -1,5 +1,6 @@ import { defineCommandMenuItem, + isSelectAll, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS, } from 'twenty-sdk/define'; @@ -15,4 +16,5 @@ export default defineCommandMenuItem({ GENERATE_CALL_RECORDING_SUMMARY_FRONT_COMPONENT_UNIVERSAL_IDENTIFIER, label: 'Generate call summary', availabilityType: 'RECORD_SELECTION', + conditionalAvailabilityExpression: !isSelectAll, }); diff --git a/packages/twenty-apps/public/people-data-labs/package.json b/packages/twenty-apps/public/people-data-labs/package.json index 36a2a77c4a..aa00763e9e 100644 --- a/packages/twenty-apps/public/people-data-labs/package.json +++ b/packages/twenty-apps/public/people-data-labs/package.json @@ -1,6 +1,6 @@ { "name": "@twentyhq/people-data-labs", - "version": "1.0.9", + "version": "1.0.10", "description": "People Data Labs enrichment app for Twenty", "license": "MIT", "engines": { diff --git a/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-companies.ts b/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-companies.ts index 3228e6dc2d..95d2ac7766 100644 --- a/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-companies.ts +++ b/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-companies.ts @@ -1,4 +1,4 @@ -import { defineCommandMenuItem, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-sdk/define'; +import { defineCommandMenuItem, isSelectAll, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-sdk/define'; import { PDL_COMMAND_MENU_ITEM_UNIVERSAL_IDENTIFIERS, PDL_FRONT_COMPONENT_UNIVERSAL_IDENTIFIERS @@ -11,4 +11,5 @@ export default defineCommandMenuItem({ PDL_FRONT_COMPONENT_UNIVERSAL_IDENTIFIERS.enrichCompanies, label: 'Enrich companies', availabilityType: 'RECORD_SELECTION', + conditionalAvailabilityExpression: !isSelectAll, }); diff --git a/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-people.ts b/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-people.ts index 1e339e8cc6..f2471e652d 100644 --- a/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-people.ts +++ b/packages/twenty-apps/public/people-data-labs/src/command-menu-items/enrich-people.ts @@ -1,4 +1,4 @@ -import { defineCommandMenuItem, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-sdk/define'; +import { defineCommandMenuItem, isSelectAll, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-sdk/define'; import { PDL_COMMAND_MENU_ITEM_UNIVERSAL_IDENTIFIERS, PDL_FRONT_COMPONENT_UNIVERSAL_IDENTIFIERS @@ -11,4 +11,5 @@ export default defineCommandMenuItem({ PDL_FRONT_COMPONENT_UNIVERSAL_IDENTIFIERS.enrichPeople, label: 'Enrich people', availabilityType: 'RECORD_SELECTION', + conditionalAvailabilityExpression: !isSelectAll, });