Jotai 13 (#18178)
## Recoil to Jotai Migration — PR 13: Workflow, Page Layout, AI, Activities, Settings, SSE & Remaining Modules ### Summary This is the 13th PR in the [14-PR migration series](packages/twenty-front/src/modules/ui/utilities/state/jotai/MIGRATION_PLAN.md) to replace Recoil with Jotai as the state management library in `twenty-front`. This PR migrates the remaining consumer code across all modules — updating ~1,076 files with ~10k insertions/deletions. ### What changed **New Jotai infrastructure (13 new files):** - `createComponentSelectorV2` and `createComponentFamilySelectorV2` — instance-scoped derived atoms, replacing Recoil's component selectors - 6 new hooks: `useRecoilComponentSelectorValueV2`, `useRecoilComponentFamilySelectorValueV2`, `useRecoilComponentSelectorCallbackStateV2`, `useRecoilComponentFamilySelectorCallbackStateV2`, `useRecoilComponentStateCallbackStateV2`, `useRecoilComponentFamilyStateCallbackStateV2` - New types: `ComponentSelectorV2`, `ComponentFamilySelectorV2`, `SelectorCallbacksV2` - Extended `buildGetHelper` to support the new selector patterns **State definition migrations:** - `createState()` → `createStateV2()` (Jotai `atom()`) - `createFamilyState()` → `createFamilyStateV2()` (Jotai `atom()` with family cache) - Recoil `selector`/`selectorFamily` → Jotai derived `atom()` via V2 utilities **Hook migrations (~2,400 removed, ~1,545 added V2 equivalents):** - `useRecoilValue` → `useRecoilValueV2` - `useRecoilState` → `useRecoilStateV2` - `useSetRecoilState` → `useSetRecoilStateV2` - `useRecoilCallback` → `useCallback` + `jotaiStore.get/set` - `useRecoilComponentValue` → `useRecoilComponentValueV2` - `useSetRecoilComponentState` → `useSetRecoilComponentStateV2` - `useRecoilComponentFamilyValue` → `useRecoilComponentFamilyValueV2` / `useFamilySelectorValueV2` - ~397 direct `import from 'recoil'` removed **Deleted files (9 files):** - `dateLocaleState.ts` — consolidated - `currentAIChatThreadTitleStateV2.ts` — renamed to replace the original - `isCommandMenuOpenedState.ts` — removed - `filesFieldUploadState.ts` — replaced by V2 - `recordStoreFamilySelector.ts`, `recordStoreFieldValueSelector.ts`, `recordStoreRecordsSelector.ts` — replaced by V2 equivalents - `settingsAllRolesSelector.ts` — replaced by `useSettingsAllRoles` hook - `settingsRoleIdsStateV2.ts` — consolidated **Modules migrated:** - Workflow (diagram, steps, variables, filters) - Page Layout (widgets, fields, graph, tabs) - AI (chat, agents, browsing context) - Activities (rich text editor, targets, timeline) - Action Menu (single/multiple record actions) - Command Menu (navigation, history, pages, workflow) - Context Store - Record Board, Record Table, Record Calendar, Record Index - Record Field, Record Filter, Record Sort, Record Group - Record Drag, Record Picker, Record Store - Views (view bar, view picker, filters, sorts) - Settings (roles, permissions, SSO, security, data model, developers, domains) - SSE (event streams, subscriptions) - Spreadsheet Import - Auth, Favorites, Front Components, Information Banner
This commit is contained in:
@@ -3,8 +3,9 @@ import { pageLayoutDraftComponentState } from '@/page-layout/states/pageLayoutDr
|
||||
import { sortTabsByPosition } from '@/page-layout/utils/sortTabsByPosition';
|
||||
import { calculateNewPosition } from '@/ui/layout/draggable-list/utils/calculateNewPosition';
|
||||
import { useAvailableComponentInstanceIdOrThrow } from '@/ui/utilities/state/component-state/hooks/useAvailableComponentInstanceIdOrThrow';
|
||||
import { useRecoilComponentCallbackState } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentCallbackState';
|
||||
import { useRecoilCallback } from 'recoil';
|
||||
import { useRecoilComponentStateCallbackStateV2 } from '@/ui/utilities/state/jotai/hooks/useRecoilComponentStateCallbackStateV2';
|
||||
import { useStore } from 'jotai';
|
||||
import { useCallback } from 'react';
|
||||
|
||||
export const useMovePageLayoutTab = (pageLayoutIdFromProps?: string) => {
|
||||
const pageLayoutId = useAvailableComponentInstanceIdOrThrow(
|
||||
@@ -12,67 +13,67 @@ export const useMovePageLayoutTab = (pageLayoutIdFromProps?: string) => {
|
||||
pageLayoutIdFromProps,
|
||||
);
|
||||
|
||||
const pageLayoutDraftState = useRecoilComponentCallbackState(
|
||||
const pageLayoutDraftState = useRecoilComponentStateCallbackStateV2(
|
||||
pageLayoutDraftComponentState,
|
||||
pageLayoutId,
|
||||
);
|
||||
|
||||
const moveLeft = useRecoilCallback(
|
||||
({ set }) =>
|
||||
(tabId: string) => {
|
||||
set(pageLayoutDraftState, (prev) => {
|
||||
const sorted = sortTabsByPosition(prev.tabs);
|
||||
const index = sorted.findIndex((t) => t.id === tabId);
|
||||
if (index <= 0) return prev;
|
||||
const store = useStore();
|
||||
|
||||
const items = sorted.filter((t) => t.id !== tabId);
|
||||
const destinationIndex = index - 1;
|
||||
const sourceIndex = index;
|
||||
const moveLeft = useCallback(
|
||||
(tabId: string) => {
|
||||
store.set(pageLayoutDraftState, (prev) => {
|
||||
const sorted = sortTabsByPosition(prev.tabs);
|
||||
const index = sorted.findIndex((t) => t.id === tabId);
|
||||
if (index <= 0) return prev;
|
||||
|
||||
const newPosition = calculateNewPosition({
|
||||
destinationIndex,
|
||||
sourceIndex,
|
||||
items,
|
||||
});
|
||||
const items = sorted.filter((t) => t.id !== tabId);
|
||||
const destinationIndex = index - 1;
|
||||
const sourceIndex = index;
|
||||
|
||||
return {
|
||||
...prev,
|
||||
tabs: prev.tabs.map((t) =>
|
||||
t.id === tabId ? { ...t, position: newPosition } : t,
|
||||
),
|
||||
};
|
||||
const newPosition = calculateNewPosition({
|
||||
destinationIndex,
|
||||
sourceIndex,
|
||||
items,
|
||||
});
|
||||
},
|
||||
[pageLayoutDraftState],
|
||||
|
||||
return {
|
||||
...prev,
|
||||
tabs: prev.tabs.map((t) =>
|
||||
t.id === tabId ? { ...t, position: newPosition } : t,
|
||||
),
|
||||
};
|
||||
});
|
||||
},
|
||||
[pageLayoutDraftState, store],
|
||||
);
|
||||
|
||||
const moveRight = useRecoilCallback(
|
||||
({ set }) =>
|
||||
(tabId: string) => {
|
||||
set(pageLayoutDraftState, (prev) => {
|
||||
const sorted = sortTabsByPosition(prev.tabs);
|
||||
const index = sorted.findIndex((t) => t.id === tabId);
|
||||
if (index < 0 || index >= sorted.length - 1) return prev;
|
||||
const moveRight = useCallback(
|
||||
(tabId: string) => {
|
||||
store.set(pageLayoutDraftState, (prev) => {
|
||||
const sorted = sortTabsByPosition(prev.tabs);
|
||||
const index = sorted.findIndex((t) => t.id === tabId);
|
||||
if (index < 0 || index >= sorted.length - 1) return prev;
|
||||
|
||||
const items = sorted.filter((t) => t.id !== tabId);
|
||||
const destinationIndex = index + 1;
|
||||
const sourceIndex = index;
|
||||
const items = sorted.filter((t) => t.id !== tabId);
|
||||
const destinationIndex = index + 1;
|
||||
const sourceIndex = index;
|
||||
|
||||
const newPosition = calculateNewPosition({
|
||||
destinationIndex,
|
||||
sourceIndex,
|
||||
items,
|
||||
});
|
||||
|
||||
return {
|
||||
...prev,
|
||||
tabs: prev.tabs.map((t) =>
|
||||
t.id === tabId ? { ...t, position: newPosition } : t,
|
||||
),
|
||||
};
|
||||
const newPosition = calculateNewPosition({
|
||||
destinationIndex,
|
||||
sourceIndex,
|
||||
items,
|
||||
});
|
||||
},
|
||||
[pageLayoutDraftState],
|
||||
|
||||
return {
|
||||
...prev,
|
||||
tabs: prev.tabs.map((t) =>
|
||||
t.id === tabId ? { ...t, position: newPosition } : t,
|
||||
),
|
||||
};
|
||||
});
|
||||
},
|
||||
[pageLayoutDraftState, store],
|
||||
);
|
||||
|
||||
return { moveLeft, moveRight };
|
||||
|
||||
Reference in New Issue
Block a user