feat(dashboard): extend number format option to bar, line and pie charts (#23505)
https://discord.com/channels/1130383047699738754/1509604545381142649 Extends the Format option (Short/Full) added for the Number widget in #21521 to bar, line and pie charts. Format controls the numbers printed on the chart face: data labels and the pie center metric. Axis ticks stay abbreviated and tooltips always show the full value. Defaults to Short, so existing charts render unchanged. Server: nullable `numberFormat` on the bar/line/pie configuration DTOs, exposed in the dashboard AI tool schema. No migration, configuration is jsonb. Deferred: - The Format row has no visible effect while data labels are off, since tooltips are always full. - Number widget format defaults differ by field type (CURRENCY defaults to Short, NUMBER to Full). Pre-existing, untouched here. https://github.com/user-attachments/assets/0778f08a-6681-4e7a-8716-fb3026d1e01f <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/23505?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
This commit is contained in:
+15
@@ -63,6 +63,21 @@ describe('transformAggregateRawValueIntoAggregateDisplayValue', () => {
|
||||
).toBe('153,909');
|
||||
});
|
||||
|
||||
it('should format large COUNT values with the SHORT chart number format', () => {
|
||||
expect(
|
||||
transformAggregateRawValueIntoAggregateDisplayValue({
|
||||
aggregateFieldMetadataItem: undefined,
|
||||
aggregateOperation: AggregateOperations.COUNT,
|
||||
aggregateRawValue: 153909,
|
||||
dateFormat: DateFormat.DAY_FIRST,
|
||||
timeFormat: TimeFormat.HOUR_24,
|
||||
localeCatalog: enUS,
|
||||
timeZone: 'UTC',
|
||||
chartNumberFormat: ChartNumberFormat.SHORT,
|
||||
}),
|
||||
).toBe('153.9k');
|
||||
});
|
||||
|
||||
it('should format large COUNT values respecting the SPACES_AND_COMMA number format', () => {
|
||||
expect(
|
||||
transformAggregateRawValueIntoAggregateDisplayValue({
|
||||
|
||||
+5
-1
@@ -46,7 +46,11 @@ export const transformAggregateRawValueIntoAggregateDisplayValue = ({
|
||||
aggregateOperation as AggregateOperations,
|
||||
)
|
||||
) {
|
||||
return formatNumber(Number(aggregateRawValue), { format: numberFormat });
|
||||
const countValue = Number(aggregateRawValue);
|
||||
|
||||
return chartNumberFormat === ChartNumberFormat.SHORT
|
||||
? formatToShortNumber(countValue)
|
||||
: formatNumber(countValue, { format: numberFormat });
|
||||
} else if (!isDefined(aggregateFieldMetadataItem)) {
|
||||
return '-';
|
||||
} else if (
|
||||
|
||||
Reference in New Issue
Block a user