From 04a304aa993c6391faeb7e22d1195fd533c5e676 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?= <71827178+bosiraphael@users.noreply.github.com> Date: Mon, 15 Jun 2026 11:29:40 +0200 Subject: [PATCH] Ignore generated Storybook/Argos screenshot output (#21589) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Context `packages/twenty-front/screenshots/` (and the equivalent under other Storybook packages) holds Argos visual-regression baselines that are generated on demand and not meant to be committed. The existing rules in `.gitignore` were: ``` screenshots/ !**/screenshots/ ``` The `!**/screenshots/` negation was added so app images committed under `public/screenshots/` (github-connector) and `assets/screenshots/` (codex-plugin) stay tracked — but it is too broad: it also re-includes the generated output, so a `git add -A` can accidentally commit hundreds of baseline PNGs. ## What this does Narrows the negation to the two locations where screenshots are intentionally committed: ``` screenshots/ !**/public/screenshots/ !**/assets/screenshots/ ``` Generated `screenshots/` directories at package roots (twenty-front, twenty-ui, twenty-ui-deprecated, twenty-front-component-renderer) are now ignored again, while committed app images remain tracked. Verified with `git check-ignore`. Review in cubic --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index b89a0bdce4..a9c5855d5b 100644 --- a/.gitignore +++ b/.gitignore @@ -57,4 +57,5 @@ TRANSLATION_QA_REPORT.md .playwright-cli/ output/playwright/ screenshots/ -!**/screenshots/ +!**/public/screenshots/ +!**/assets/screenshots/