Rename prefetchViewStates in coreViewStates (#14373)

## Context View system used to rely on workspaceSchema views and was loaded in what we called the "prefetch". We have recently migrated views to core.coreViews and the states should now be named after coreViews Fixes: https://github.com/twentyhq/twenty/issues/14349
2025-09-09 19:11:17 +02:00
parent 9322853641
commit 002322c8e3
41 changed files with 251 additions and 138 deletions
@@ -0,0 +1,142 @@
+import { getSnapshotValue } from '@/ui/utilities/state/utils/getSnapshotValue';
+import { coreViewsState } from '@/views/states/coreViewState';
+import { type CoreViewWithRelations } from '@/views/types/CoreViewWithRelations';
+import { useApolloClient } from '@apollo/client';
+import { useRecoilCallback } from 'recoil';
+import { isDefined } from 'twenty-shared/utils';
+import { type CoreViewField } from '~/generated/graphql';
+import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
+
+export const useTriggerViewFieldOptimisticEffect = () => {
+  const apolloClient = useApolloClient();
+
+  const cache = apolloClient.cache;
+
+  const triggerViewFieldOptimisticEffect = useRecoilCallback(
+    ({ set, snapshot }) =>
+      ({
+        createdViewFields = [],
+        updatedViewFields = [],
+        deletedViewFields = [],
+      }: {
+        createdViewFields?: CoreViewField[];
+        updatedViewFields?: CoreViewField[];
+        deletedViewFields?: CoreViewField[];
+      }) => {
+        const coreViews = getSnapshotValue(snapshot, coreViewsState);
+        let newCoreViews = [...coreViews];
+
+        createdViewFields.forEach((createdViewField) => {
+          cache.modify<CoreViewWithRelations>({
+            id: cache.identify({
+              __typename: 'CoreView',
+              id: createdViewField.viewId,
+            }),
+            fields: {
+              viewFields: (existingViewFields, { toReference }) => [
+                ...(existingViewFields ?? []),
+                toReference(createdViewField),
+              ],
+            },
+          });
+          const toBeModifiedCoreView = newCoreViews.find(
+            (coreView) => coreView.id === createdViewField.viewId,
+          );
+          if (isDefined(toBeModifiedCoreView)) {
+            newCoreViews = [
+              ...newCoreViews.filter(
+                (coreView) => coreView.id !== createdViewField.viewId,
+              ),
+              {
+                ...toBeModifiedCoreView,
+                viewFields: [
+                  ...toBeModifiedCoreView.viewFields,
+                  createdViewField,
+                ],
+              },
+            ];
+          }
+        });
+
+        updatedViewFields.forEach((updatedViewField) => {
+          cache.modify<CoreViewWithRelations>({
+            id: cache.identify({
+              __typename: 'CoreView',
+              id: updatedViewField.viewId,
+            }),
+            fields: {
+              viewFields: (existingViewFields, { readField, toReference }) =>
+                existingViewFields.map((viewField) => {
+                  const viewFieldId = readField<string>('id', viewField);
+                  if (viewFieldId === updatedViewField.id) {
+                    return toReference(updatedViewField);
+                  }
+                  return viewField;
+                }),
+            },
+          });
+          const toBeModifiedCoreView = newCoreViews.find(
+            (coreView) => coreView.id === updatedViewField.viewId,
+          );
+          if (isDefined(toBeModifiedCoreView)) {
+            newCoreViews = [
+              ...newCoreViews.filter(
+                (coreView) => coreView.id !== updatedViewField.viewId,
+              ),
+              {
+                ...toBeModifiedCoreView,
+                viewFields: [
+                  ...toBeModifiedCoreView.viewFields.filter(
+                    (viewField) => viewField.id !== updatedViewField.id,
+                  ),
+                  updatedViewField,
+                ],
+              },
+            ];
+          }
+        });
+
+        deletedViewFields.forEach((deletedViewField) => {
+          cache.modify<CoreViewWithRelations>({
+            id: cache.identify({
+              __typename: 'CoreView',
+              id: deletedViewField.viewId,
+            }),
+            fields: {
+              viewFields: (existingViewFields, { readField }) =>
+                existingViewFields.filter(
+                  (viewField) =>
+                    readField('id', viewField) !== deletedViewField.id,
+                ),
+            },
+          });
+          const toBeModifiedCoreView = newCoreViews.find(
+            (coreView) => coreView.id === deletedViewField.viewId,
+          );
+
+          if (isDefined(toBeModifiedCoreView)) {
+            newCoreViews = [
+              ...newCoreViews.filter(
+                (coreView) => coreView.id !== deletedViewField.viewId,
+              ),
+              {
+                ...toBeModifiedCoreView,
+                viewFields: toBeModifiedCoreView.viewFields.filter(
+                  (viewField) => viewField.id !== deletedViewField.id,
+                ),
+              },
+            ];
+          }
+        });
+
+        if (!isDeeplyEqual(coreViews, newCoreViews)) {
+          set(coreViewsState, newCoreViews);
+        }
+      },
+    [cache],
+  );
+
+  return {
+    triggerViewFieldOptimisticEffect,
+  };
+};