houseassassin/remnawave-bedolaga-telegram-bot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: promo group discount applied to restricted tariffs in autopay

Browse Source 
The pricing engine applied promo group discounts unconditionally,
without checking if the tariff is available for the user's promo group.

In autopay: user with VIP group (60% discount, restricted to Premium
tariff) would get 60% off when auto-renewing a Basic tariff that their
group should not cover.

Fix: in _calculate_tariff_core, check tariff.is_available_for_promo_group
before applying group discounts. If tariff is not available for the
user's promo group, the discount is zeroed — subscription renews at
full price. Protects ALL pricing paths (autopay, recurrent, manual).
This commit is contained in:
Fringg
2026-04-29 07:09:55 +03:00
parent fb857d792b
commit 4ab5928b61
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/services/pricing_engine.py
+3
View File
@@ -603,6 +603,9 @@ class PricingEngine:
period_pct = 0 period_pct = 0
devices_pct = 0 devices_pct = 0
promo_group = self.resolve_promo_group(user) promo_group = self.resolve_promo_group(user)
# Only apply promo group discount if the tariff is available for this group
if promo_group is not None and not tariff.is_available_for_promo_group(promo_group.id):
promo_group = None
if promo_group is not None: if promo_group is not None:
period_pct = promo_group.get_discount_percent('period', period_days) period_pct = promo_group.get_discount_percent('period', period_days)
devices_pct = promo_group.get_discount_percent('devices', period_days) devices_pct = promo_group.get_discount_percent('devices', period_days)